chore(desktop): bump version to 1.9.4 (host-service 0.8.3 -> 0.8.4)#4589
Conversation
|
Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo package versions are incremented: desktop app from 1.9.1 to 1.9.4 and host-service from 0.8.3 to 0.8.4. No other manifest fields, dependencies, or code are modified. ChangesPackage version updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR bumps the
Confidence Score: 4/5Safe to merge — only version strings are changed, with no functional code impact. Both changes are pure version bumps in package.json files. The host-service bump is sequential (0.8.3 → 0.8.4). The desktop bump jumps from 1.9.1 directly to 1.9.4, skipping two patch versions that do not appear in the git history on this branch, which may indicate out-of-band releases or a minor versioning inconsistency worth confirming. apps/desktop/package.json — the non-sequential version jump warrants a quick confirmation that 1.9.2 and 1.9.3 were intentionally skipped.
|
| Filename | Overview |
|---|---|
| apps/desktop/package.json | Version bumped from 1.9.1 to 1.9.4, skipping 1.9.2 and 1.9.3; no other changes. |
| packages/host-service/package.json | Version bumped sequentially from 0.8.3 to 0.8.4; no other changes. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["@superset/desktop\nv1.9.1"] -->|"bump (skips 1.9.2, 1.9.3)"| B["@superset/desktop\nv1.9.4"]
C["@superset/host-service\nv0.8.3"] -->|"sequential bump"| D["@superset/host-service\nv0.8.4"]
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/desktop/package.json:5
**Non-sequential version jump**
The desktop version jumps from `1.9.1` directly to `1.9.4`, skipping `1.9.2` and `1.9.3`. The previous bump commit (`d85dd2f6a`) shows `1.9.1` as the last published version, and no intermediate bumps appear in the git log. If `1.9.2` and `1.9.3` were released on a separate branch or out of band, this is fine — but if not, the gap may cause confusion in release tracking and auto-update checks that compare version strings sequentially.
Reviews (1): Last reviewed commit: "chore(desktop): bump version to 1.9.4 (h..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "productName": "Superset", | ||
| "description": "The last developer tool you'll ever need", | ||
| "version": "1.9.1", | ||
| "version": "1.9.4", |
There was a problem hiding this comment.
The desktop version jumps from 1.9.1 directly to 1.9.4, skipping 1.9.2 and 1.9.3. The previous bump commit (d85dd2f6a) shows 1.9.1 as the last published version, and no intermediate bumps appear in the git log. If 1.9.2 and 1.9.3 were released on a separate branch or out of band, this is fine — but if not, the gap may cause confusion in release tracking and auto-update checks that compare version strings sequentially.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/package.json
Line: 5
Comment:
**Non-sequential version jump**
The desktop version jumps from `1.9.1` directly to `1.9.4`, skipping `1.9.2` and `1.9.3`. The previous bump commit (`d85dd2f6a`) shows `1.9.1` as the last published version, and no intermediate bumps appear in the git log. If `1.9.2` and `1.9.3` were released on a separate branch or out of band, this is fine — but if not, the gap may cause confusion in release tracking and auto-update checks that compare version strings sequentially.
How can I resolve this? If you propose a fix, please make it concise.
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Already integrated, superseded by current versions, or net-empty in this fork: superset-sh#3881 superset-sh#3887 superset-sh#3917 superset-sh#3925 superset-sh#3940 superset-sh#3956 superset-sh#3961 superset-sh#3974 superset-sh#4017 superset-sh#4048 superset-sh#4049 superset-sh#4055 superset-sh#4063 superset-sh#4070 superset-sh#4092 superset-sh#4110 superset-sh#4138 superset-sh#4159 superset-sh#4163 superset-sh#4164 superset-sh#4209 superset-sh#4210 superset-sh#4249 superset-sh#4349 superset-sh#4405 superset-sh#4462 superset-sh#4464 superset-sh#4494 superset-sh#4495 superset-sh#4500 superset-sh#4535 superset-sh#4541 superset-sh#4566 superset-sh#4580 superset-sh#4589 superset-sh#4593 superset-sh#4603 superset-sh#4637 superset-sh#4642 superset-sh#4655 superset-sh#4657 superset-sh#4659 superset-sh#4685 superset-sh#4692 superset-sh#4745 superset-sh#4789 superset-sh#4797 superset-sh#4824 superset-sh#4835 superset-sh#4847 superset-sh#4885 superset-sh#4896.
1 participant
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Summary by cubic
Prepare the 1.9.4 desktop release and align package versions by updating
@superset/desktopand@superset/host-servicefor consistency.@superset/desktop: 1.9.1 → 1.9.4@superset/host-service: 0.8.3 → 0.8.4Written for commit 384ba9b. Summary will update on new commits.
Summary by CodeRabbit